build: update flatbuffers dependency to v23.5.26#2274
Merged
mergify[bot] merged 2 commits intotensorflow:mainfrom Oct 18, 2023
Merged
build: update flatbuffers dependency to v23.5.26#2274mergify[bot] merged 2 commits intotensorflow:mainfrom
mergify[bot] merged 2 commits intotensorflow:mainfrom
Conversation
Contributor
|
We also need to update the version downloaded as part of the make build: https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/tools/make/flatbuffers_download.sh#L57 |
rkuester
force-pushed
the
feat-build-update-flatbuffers
branch
from
527accd to
58cc594
Compare
rkuester
force-pushed
the
feat-build-update-flatbuffers
branch
2 times, most recently
from
36a80ac to
3fe216d
Compare
Update the third_party flatbuffers library to v23.5.26, the current version in upstream TF. Synchronize the override BUILD and build_defs.bzl files with those from upstream TF at e4485c98eae. Also update the Makefile build, which downloads flatbuffers separately. Rebase the patch applied to the download. Regenerate the generated-and-checked-in schemas (see ci/sync_from_upstream_tf.sh and codegen/preprocessor/ update_schema.sh), because they are stamped with the version of the flatbuffers library, and fail a static_assert if they are built with a different version of flatbuffers than they were generated with. BUG=unsuccessful attempt to fix warning in tensorflow#2183
rkuester
force-pushed
the
feat-build-update-flatbuffers
branch
from
3fe216d to
ba98cf1
Compare
rascani
approved these changes
Oct 16, 2023
Contributor
Author
|
@rascani, the merge is failing for a reason I've not encountered before: https://github.com/tensorflow/tflite-micro/pull/2274/checks?check_run_id=17757924691. Can you please take a look? |
Contributor
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
Contributor
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the third_party flatbuffers library to v23.5.26, the
current version in upstream TF. Synchronize the override BUILD
and build_defs.bzl files with those from upstream TF at
e4485c98eae.
Also update the Makefile build, which downloads flatbuffers
separately. Rebase the patch applied to the download.
Regenerate the generated-and-checked-in schemas (see
ci/sync_from_upstream_tf.sh and codegen/preprocessor/
update_schema.sh), because they are stamped with the version of
the flatbuffers library, and fail a static_assert if they are
built with a different version of flatbuffers than they were
generated with.
BUG=unsuccessful attempt to fix warning in #2183